This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Rounding mode support for hexadecimal float parsing, with improvements to error handling #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
approved these changes
Mar 18, 2025
quaternic
force-pushed
the
hex-parse-rounding
branch
from
06ea7d2 to
d551777
Compare
Thanks! I'm sorry for taking my time as well. I fixed the comment and rebased; and CI seems to still be happy with it. Could you squash this while merging? |
quaternic
changed the title
|
There are some magic numbers and literals, it would be good to make them constants for better readability. |
quaternic
commented
Apr 14, 2025
Co-authored-by: quaternic <[email protected]>
tgross35
reviewed
Apr 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing errors are now bubbled up part of the way, but that needs some more work.
Rounding should be correct, and the
Statusreturned byparse_anyshould have the correct bits set. These are used for the current (unchanged) behaviour of the surface level functions likehf64: panic on invalid inputs, or values that aren't exactly representable.