Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Rounding mode support for hexadecimal float parsing, with improvements to error handling #529

Merged
merged 10 commits into from
Apr 15, 2025
Merged

Rounding mode support for hexadecimal float parsing, with improvements to error handling #529

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b46eb8a
implement rounding for the hex float parsing, and prepare to improve …
quaternic Mar 3, 2025
bba23d4
cargo fmt
quaternic Mar 3, 2025
603c840
more parsing fixes
quaternic Mar 4, 2025
b85e1ac
fix msrv, clippy
quaternic Mar 4, 2025
8d87c19
more mrsv fixes
quaternic Mar 4, 2025
5a2786b
snip dead code
quaternic Mar 4, 2025
bab43ef
disable problematic test for most targets
quaternic Mar 4, 2025
d551777
Fix broken comment
quaternic Apr 13, 2025
e21cb07
Update src/math/support/hex_float.rs
tgross35 Apr 15, 2025
26fcd19
Update src/math/support/hex_float.rs
tgross35 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/math/support/hex_float.rs
  • Loading branch information
@tgross35
tgross35 authored Apr 15, 2025
commit 26fcd19114aae190e197142c4113918cc82ffbc3
4 changes: 2 additions & 2 deletions src/math/support/hex_float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,9 @@ const fn shr2_round(mut x: u128, round: Round) -> u128 {
let t = (x as u32) & 0b111;
x >>= 2;
match round {
// Look-up-table on the last three bits for when to round up
// Look-up-table on the last three bits for when to round up
Round::Nearest => x + ((0b11001000_u8 >> t) & 1) as u128,

Round::Negative => x,
Round::Zero => x,
Round::Positive => x + (t & 0b11 != 0) as u128,
Expand Down
Loading