feat: implement managed control planes #723
Open
+2,752
−4,897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
implement-managed-control-planes-controller
branch
8 times, most recently
from
ec410d1 to
28b504d
Compare
smira
reviewed
Nov 6, 2024
Unix4ever
commented
Nov 6, 2024
Unix4ever
commented
Nov 6, 2024
Unix4ever
force-pushed
the
implement-managed-control-planes-controller
branch
4 times, most recently
from
e1234e4 to
f4867d3
Compare
Cluster template now has ``` managed: enable: true|false ``` configuration in the control planes model. Creating managed control planes will be possible only if the Omni account is configured with the provider to use for managed control planes, otherwise resource validation won't allow creating the machine set with such configuration. Also drop `MachineRequestSet` allocation mode from the machine set, remove source there, as it doesn't make much sense: for managed control planes it should always use the machine request set name with the same name as the machine set. Config patches for managed mode are going to be added in the follow-up PRs. Fixes: siderolabs#705 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
implement-managed-control-planes-controller
branch
from
f4867d3 to
18095de
Compare
Unix4ever
added a commit
to Unix4ever/omni
that referenced
this pull request
Apr 29, 2025
This option is redundant. It was inteded for MCP, but the MCP implementation will not be using it, so we should stop dragging it along anymore. This change was extracted from siderolabs#723 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
added a commit
to Unix4ever/omni
that referenced
this pull request
Apr 29, 2025
This option is redundant. It was inteded for MCP, but the MCP implementation will not be using it, so we should stop dragging it along anymore. This change was extracted from siderolabs#723 Signed-off-by: Artem Chernyshev <[email protected]>
|
This PR is stale because it has been open 45 days with no activity. |
|
not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster template now has
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni account is configured with the provider to use for managed control planes, otherwise resource validation won't allow creating the machine set with such configuration.
Also drop
MachineRequestSetallocation mode from the machine set, remove source there, as it doesn't make much sense: for managed control planes it should always use the machine request set name with the same name as the machine set.Config patches for managed mode are going to be added in the follow-up PRs.
Fixes: #705