pulling upstream changes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same vars it will run in all of them. This can cause issues in fedoras since certain things don't need to run there
Fedora support
Disable Fedora testing, as PostgreSQL v9.3 doesn't exist
Squashed, original work from @gclough * Fixed wrong handler name * change vagrantfile to point to the official centos images since those support different providers. * changed the vagrant file to use become since sudo is going away and added default verbose. * changed install_yum.yml to use a block to reduce the transactions made. * added retry files to gitignore. * added systemctl handler to restart when using OS that use systemctl. * changed to use the handlers to restart the services and enable the services during boot instead of having extra tasks. I removed them since they are not necessary. * Convert from using "psql" to using the Ansible module "postgresql_ext", which I suspect is a more reliable method. * changed to check for systemd. * Added extra tests for travis to create extensions in "foobar" database * Increase the travis test coverage to include popular options (#305) * Increse the travis test coverage to include popular options * Fixed a missing quote... * Fixed syntax for options, and make postgis.yml RedHat compatible... ish * Looks like pgtune won't install either, as the epel repo isn't in the docker image. Taking it out too.. * Changing parameters to be in JSON format, for consumption on the command line * Adding a space to trigger a travis build * Remove the space, as travis didn't build anyway... :-/ * Debugging... why don't travis kick in... * Revert travis changes, to try and get it to trigger * Fixed typo in JSON parameters * Removed travis updates, and put parameters into postgresql.yml * Squashing all commits. Increases travis coverage, but not all are enabled yet. Other pull requests need to be merged first, as the tests for them fail. * Added meta data for CentOS and RedHat, plus added tags to help with searches * Fixed CenOS/RedHat naming... should be EL. Also added tags to help people find it on Galaxy * Quote all string variables, and add spaces around variables "{{ var }}" instead of "{{var}"" * Crosschecked, and found some that I missed. * Octal numbers need to be quoted, otherwise they get converted to Decimal * Extended and adapted to install PostgreSQL 10 for CentOS and Ubuntu (#267) * Extended and adapted to install PostgreSQL 10 for CentOS and Ubuntu Tested with ansible 2.4.1 for Ubuntu 16.04 and CentOS-7.4 - replaced deprecated 'include:' by 'include_tasks:' for ansible 2.4.1 - added config and config template for postgresql 10 - adapted defaults.yml - adapted templates/etc_systemd_system_postgresql.service.d_custom.conf.j2 for PostgreSQL 10 the template outputs the wrong line: ExecStartPre=/usr/pgsql-10/bin/postgresql10-check-db-dir the correct one must include an additional '-': ExecStartPre=/usr/pgsql-10/bin/postgresql-10-check-db-dir * Removed tabs from defaults/main.yml. * Adapted .travis.yml and yml files to run tests successfully for all given ansible versions. - added a test for ansible 2.4.2.0/posgresql 10. - replaced newer 'include_task' by 'include' again so that the role can be used with older ansible versions. NOTE: 'include' is deprecated and will be removed in ansible 2.8. - commeted out docker based tests because they do not run successfully and I do not know docker ;-) * Bug fix. Removed remains for my local teste in test/playbook.yml. * Bug fix and refinement for postgresql.conf-10.* . - added max_parallel_workers to postgresql.conf-10.j2 (forgotten/deleted in previous version) - hard coded value for wal_retrieve_retry_interval in postgresql.conf-10.j2 replaced by ansible variable Changes to be committed: modified: Vagrantfile modified: defaults/main.yml modified: templates/postgresql.conf-10.j2 modified: vagrant-inventory * Added suggestions from gclough. Changes to be committed: modified: Vagrantfile modified: defaults/main.yml modified: templates/HOWTO.postgresql.conf modified: templates/etc_systemd_system_postgresql.service.d_custom.conf.j2 modified: tests/playbook.yml modified: tests/vars.yml modified: vagrant-inventory * Replaced vagrant setup by project's master branch. * Updated tests/docker/group_vars/all.yml to include version 10. * Uncommented 'no_log: true' in users.yml. * Uncommented user baz in tests/docker/group_vars/postgresql.yml. * Recreated user baz but without passwd. We need him as database owner :-). * Added encrypted passwd for user baz. * Commented need for encrypted password if version >= 10. * Reenabled no_log: true for task PostgreSQL | Make sure the PostgreSQL users are present Fixed text in templates/HOWTO.posgresql.conf * Just to trigger a new build on github. Added blank in README.md. * Second try to trigger a rebuild. Blank in README.md deleted. * Prepare for PostgreSQL v10 (and v11) (#308) * Adding future scope for v10 (already out), and v11 (Sep/18) * Fixed "CentOS" spelling, and put a request for help * fixed the syntax on dev_headers * added all the required dependencies together and deleted a tasks. Make less transactions * the other night when I started this. I forgot to add since it was a long night * accidently deleted vagrantfile * Reload conf parameters after install, so that pg_hba.conf is re-read * Updated README to show v10 support, added top 10 contributors, and li… (#330) * Updated README to show v10 support, added top 10 contributors, and linked to defaults/main.yml * Fixed typo in contributors * Reload conf parameters after install, so that pg_hba.conf is re-read * Fixed wrong handler name * Added libselinux-python dependency for selinux enabled redhat systems. * Honour those that created the role in the first place, and those that maintain it (#336) * Fixing local master * More merging of master... * Fixing it to match the *REAL* "master" * Tidied up variable and filenames for install_*.yml * Don't restrict apt/yum/dnf to specific OS types, and disable Fedora Travis * Fixed merging problems * Fixed mistake in comments * Reinstate "ansible_distribution" tests * Removed extra "and" * Removed duplicate 'name:' for dns repository
Conflicts: .travis.yml README.md Vagrantfile defaults/main.yml tasks/databases.yml tasks/extensions/dev_headers.yml tasks/extensions/postgis.yml tasks/install_yum.yml tasks/main.yml
Allow use of "--data-checksums", "--xlogdir / --waldir", and "--pwfile" during initdb
Updated synchronous_standby_names to be correct
The former default pg_hba config let any local POSIX user, and any local process, connect to postgres as any role including SUPERUSER, without providing a password. This changes the default values to safer ones: - local connections (via unix sockets) are now restricted to the role with the same name as the POSIX user - localhost network connections are subject to MD5 password authentication Those values are already used by default in distributions such as Debian and Ubuntu when pg_hba.conf is configured by apt instead of this role.
fix postgresql_log_hostname
With PostgreSQL 10, `password_encryption` is no longer a boolean. It expects either `md5` or `scram-sha-256`. The value `on` is kept as an alias of `md5` for backward compatibility.
…Postgresql on RH systems
Use pg_ctlcluster to Reload Config Files
When creating tablespaces on PostgreSQL using "CREATE TABLESPACE" statements, PostgreSQL requires that these directories already exist[1]. Allow creating tablespace directories from this role. 1. https://www.postgresql.org/docs/10/sql-createtablespace.html Co-authored-by: Samuel Githengi <[email protected]> Signed-off-by: Jason Rogena <[email protected]>
Allow Creating Directories for Tablespaces
Add role_name property. Should fix #467. [skip ci]
Ignore errors in "Add extensions to the databases" task in check mode
Ubuntu 20 (Focale Fossa) support
… into fix_ci_pipeline
fix: Fix CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.