DRY implementation of group_match_arms and surrounding utilities

[eytan-starkware]

Stack:

• Recursive lowering and sealing of enum match patterns and arms #7764
• Moved VariantMatchTree construction into the EnumVariantScopeBuilder #7763
• DRY implementation of group_match_arms and surrounding utilities #7747 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1037 at r1 (raw file):

        arms: vec![],
        location,
    });

seems like it should move into the new function.

Code quote:

    let empty_match_info = MatchInfo::Enum(MatchEnumInfo {
        concrete_enum_id,
        input: match_input,
        arms: vec![],
        location,
    });

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1410 at r1 (raw file):

    }

    fn collect_match_arms(self, concrete_variants: &[ConcreteVariant]) -> Vec<MatchArm> {

doc.

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1517 at r1 (raw file):

        .collect();

    fn lower_arm_expr(

doc

[eytan-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1037 at r1 (raw file):

Previously, orizi wrote…

seems like it should move into the new function.

This is different between Extern and Concrete so I left it outside. Maybe a bit further on I will remove this duplication (the extern/concrete difference also affects the final match_info for finishing the lowering of the match)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1410 at r1 (raw file):

Previously, orizi wrote…

doc.

Done.

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 1517 at r1 (raw file):

Previously, orizi wrote…

doc

Done.

[orizi]

Reviewed 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 329 at r3 (raw file):

/// Builds a variant match tree from the arms of a match statement.
/// The tree is used to check for unreachable patterns and represent for each variant it's .

Suggestion:

/// The tree is used to check for unreachable patterns and represent for each variant it's ????.

[eytan-starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/lower/lower_match.rs line 329 at r3 (raw file):

/// Builds a variant match tree from the arms of a match statement.
/// The tree is used to check for unreachable patterns and represent for each variant it's .

Done.

[orizi]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)