Skip to content

Moved VariantMatchTree construction into the EnumVariantScopeBuilder #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

eytan-starkware
Copy link
Contributor

@eytan-starkware eytan-starkware commented May 18, 2025

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/cairo-lang-lowering/src/lower/lower_match.rs line 1056 at r1 (raw file):

        // If we draw it as a tree we can see different branches have different types and depths:
        // ``` Either
        // ├── Either

Suggestion:

        // If we draw it as a tree we can see different branches have different types and depths:
        // ``` 
        // Either
        // ├── Either

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)

Base automatically changed from spr/main/5d520ca7 to main May 18, 2025 17:38
Copy link
Contributor Author

@eytan-starkware eytan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/lower/lower_match.rs line 1056 at r1 (raw file):

        // If we draw it as a tree we can see different branches have different types and depths:
        // ``` Either
        // ├── Either

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

@eytan-starkware eytan-starkware added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 484bf38 May 19, 2025
96 checks passed
@eytan-starkware eytan-starkware deleted the spr/main/39f4b9ed branch May 21, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants