-
Notifications
You must be signed in to change notification settings - Fork 604
Moved VariantMatchTree construction into the EnumVariantScopeBuilder #7763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41d4c42
to
5f214fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 1056 at r1 (raw file):
// If we draw it as a tree we can see different branches have different types and depths: // ``` Either // ├── Either
Suggestion:
// If we draw it as a tree we can see different branches have different types and depths:
// ```
// Either
// ├── Either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)
commit-id:39f4b9ed
5f214fb
to
2df50ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 1056 at r1 (raw file):
// If we draw it as a tree we can see different branches have different types and depths: // ``` Either // ├── Either
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)
Stack: