Allow passing multiple child nodes as arguments #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only ran |
|
Hmm, so I guess we already supported |
|
Indeed, it's when I noticed nested arrays already worked that I figured supporting this multiple argument syntax wouldn't be too complicated. |
|
OK! I’m up for this, but could you update the docs? |
|
Sure, will do 👌 |
|
I pushed some documentation changes. Do let me know if you think there's something missing. |
wooorm
approved these changes
Oct 4, 2018
|
Sorry I took a while, landed! |
wooorm
added
⛵️ status/released
🗄 area/interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other implementations—most notably
hyperscriptitself—allow passing multiple child nodes as arguments to the factory function, instead of just as a single array argument. This PR adds support for that usage tohastscript. Based on the existing tests, this shouldn't break any current behaviour, because they all passed without modification.