VTR_BUILD: -lasan not found #815
Conversation
|
@kmurray any reason why -static-libasan should not be removed? if we add the link flags, static-libasan prevent a successful build. The only error I have ran into is that Valgrind will not play nice with -fsanitize=address turned on but they should not be used together anyways. |
That is my experience also, so they should be used in a mutually exclusive manner.
I recall adding that for the reason in the comment: there was some link order dependence (libasan needed to be linked first). If that issue has been resolved and it works without static (i.e. dynamic) linking it should be fine to remove it. |
CMakeLists.txt
Outdated
| @@ -267,6 +272,9 @@ endif() | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${WARN_FLAGS} ${SANITIZE_FLAGS} ${PROFILING_FLAGS} ${COVERAGE_FLAGS} ${LOGGING_FLAGS} ${COLORED_COMPILE}") | |||
| message(STATUS "CMAKE_CXX_FLAGS: ${CMAKE_CXX_FLAGS}") | |||
|
|
|||
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${SANITIZE_LDFLAGS}") | |||
There was a problem hiding this comment.
Is it necessary to split out the linker/compiler flags here? Or is removing -static-libasan enough?
My preference is to keep it simple and avoid complicating the code. It looks like the SANITIZER_FLAGS and SANITIZER_LDFLAGS are the same. So if the fix is to remove -static-libasan we should just do that.
There was a problem hiding this comment.
updated as per request
jeanlego
force-pushed
the
static_asan_fix
branch
from
e47a674 to
72c9ee1
Compare
|
Thanks! |
Description
with the previous flags, vtr would not build with libasan.
the changes remove linking asan as a static library
Related Issue
this fixes #814
Motivation and Context
Ability to run with sanitize flags.
How Has This Been Tested?
built with gcc 9
Types of changes
Checklist: