[Manager] Impletent “Install All” button #4196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions <[email protected]>
Co-authored-by: webfiltered <[email protected]>
Co-authored-by: github-actions <[email protected]>
viva-jinyi
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
christian-byrne
requested changes
Jun 16, 2025
webfiltered
reviewed
Jun 16, 2025
There was a problem hiding this comment.
@christian-byrne Do you have capacity to review & merge this? It could go straight into 1.23.0.
Edit: The timing of this was absolutely ridiculous. >.>
|
To clean up the commit history, you can rebase instead of merging. Here's how: git checkout migration/feat/installall
git rebase mainIf there are conflicts, resolve them and run This will remove the merge commits and create a cleaner linear history. |
comfy-jinyi
pushed a commit
that referenced
this pull request
Jun 18, 2025
Co-authored-by: github-actions <[email protected]> Co-authored-by: filtered <[email protected]> Co-authored-by: Christian Byrne <[email protected]> Co-authored-by: Terry Jia <[email protected]> Co-authored-by: comfy-waifu <[email protected]> Co-authored-by: Comfy Org PR Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the "Install All" functionality for missing node packs in both the missing nodes dialog and manager dialog's missing tab.
Behavior
Missing Nodes Dialog (
LoadWorkflowWarning.vue):Manager Dialog (
ManagerDialogContent.vue):Pack Detection Logic:
useMissingNodescomposable automatically identifies missing node packsComponents
PackInstallAllButton.vue: Reusable install all button componentuseMissingNodes.ts: Core composable for missing pack detection and managementRegistrySearchBar.vueandPackActionButton.vueNotes
┆Issue is synchronized with this Notion page by Unito