Speed up col reorder call #57
Conversation
Doing a table.colReorder.order( [stuff], true ); for arrays with large length locks up the browser really bad. I've narrowed it down to the lines ```javascript var api = new $.fn.dataTable.Api( oSettings ); api.rows().invalidate(); ``` I've moved these out and already the speed of doing this on my table of ~45 columns went from ~8 seconds to <1 second. I would imagine some other optimizations could be made if I took the time to understand the code more. But it's a start?
accidentally missed a commit you made earlier
|
That looks like a good change - thanks! I probably wouldn't bother splitting the invalidate call into a separate plug-in API method for the legacy DataTables API (which I really need to upgrade ColReorder from), but rather just put it inline after the I like that its backwards compatible as well - thanks!
Finally - are you happy for this to be included under the MIT license? |
|
Oops - I misread the second commit message ("comma" rather than "commit") - second my third paragraph above! |
|
Yes that all sounds great of course. Thanks Sent from my iPhone
|
…ect API calls. - ColReorder's code makes me want to cry...
Doing a table.colReorder.order( [stuff], true ); for arrays with large length locks up the browser really bad. I've narrowed it down to the lines
I've moved these out and already the speed of doing this on my table of ~45 columns on my fairly new macbook pro went from ~8 seconds to around just over 1 second. I would imagine some other optimizations could be made if I took the time to understand the code more. Or at least issue in some timeouts to prevent the lock in. But it's a start?