Skip to content

Commit 07e096d

Browse files
authored
Merge pull request TheOdinProject#311 from bzaman/TheOdinProject#310-button-element-enhancement
TheOdinProject#310 button element enhancement
2 parents e7c367d + 20086b6 commit 07e096d

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

flex/05-flex-modal/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div class="modal">
1212
<div class="icon">!</div>
1313
<div class="header">Are you sure you want to do that?</div>
14-
<div class="close-button"></div>
14+
<button class="close-button"></button>
1515
<div class="text">Lorem ipsum dolor sit amet consectetur adipisicing elit. Pariatur excepturi id soluta, numquam minima rerum doloremque eveniet aspernatur beatae commodi. Cupiditate recusandae ad repellendus quidem consectetur sequi amet aspernatur cumque!</div>
1616
<button class="continue">Continue</button>
1717
<button class="cancel">Cancel</button>

flex/05-flex-modal/solution/solution.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,12 @@ body {
4646
display: flex;
4747
align-items: center;
4848
justify-content: center;
49+
border: 1px solid #eee;
50+
padding: 0;
4951
}
5052

5153
button {
54+
cursor: pointer;
5255
padding: 8px 16px;
5356
border-radius: 8px;
5457
}

flex/05-flex-modal/solution/solution.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<div class="icon">!</div>
1313
<div class="container">
1414
<div class="header">Are you sure you want to do that?
15-
<div class="close-button"></div>
15+
<button class="close-button"></button>
1616
</div>
1717
<div class="text">Lorem ipsum dolor sit amet consectetur adipisicing elit. Pariatur excepturi id soluta, numquam minima rerum doloremque eveniet aspernatur beatae commodi. Cupiditate recusandae ad repellendus quidem consectetur sequi amet aspernatur cumque!</div>
1818
<button class="continue">Continue</button>

flex/05-flex-modal/style.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,12 @@ body {
4646
display: flex;
4747
align-items: center;
4848
justify-content: center;
49+
border: 1px solid #eee;
50+
padding: 0;
4951
}
5052

5153
button {
54+
cursor: pointer;
5255
padding: 8px 16px;
5356
border-radius: 8px;
5457
}

0 commit comments

Comments
 (0)