#310 button element enhancement #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cursor: pointer` property added to global button. `close-button` class now has two new property to achieve design goal.
|
looks good. nice work 👍🏽 |
AngryBabushka
pushed a commit
to AngryBabushka/css-exercises
that referenced
this pull request
Feb 23, 2024
…button-element-enhancement TheOdinProject#310 button element enhancement
Oussama5379
added a commit
to Oussama5379/css-exercises
that referenced
this pull request
Feb 1, 2025
…button-element-enhancement TheOdinProject#310 button element enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Button element is technically better than
divelement when it's purpose is click event. In this case to close modal.This PR
divelement replaced withbuttonelementbuttonelement now has cursor pointer to better accessibilitybuttonis identical as it was withdivelementIssue
Closes #310
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01-flex-center: Update self checkBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection