Skip to content

Close button div need to replace with button element #310

Closed
@bzaman

Description

@bzaman

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the location for request: brief description of request format, e.g. Foundations exercises: Add exercise for XYZ

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Feature Request:
path : css-exercises/flex/05-flex-modal index.html and solution/solution.html with the class close-button need to be button element instead of div element. Button element would be more semantic and accessibility.

2. Acceptance Criteria:

  • div element with the class close-button there.
  • Need to replace with button element.
  • Will solve semantic and accessibility.
  • Best practice to use semantic element where needed especially where click event is required.

Metadata

Metadata

Assignees

Labels

Status: Needs ReviewThis issue/PR needs an initial or additional review

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions