Only collapse the y-axis for collapsible elements #5456
Conversation
...if an collapsible item is collapsed. Additional styling in the horizontal level that overflows the x-axis should still be possible.
To prevent the left and right paddings to be cut off. This will be fixed in Icinga/icingaweb2#5456. Then this commit can be reverted.
|
|
||
| .collapsible.collapsed:not(details) { | ||
| overflow: hidden; | ||
| overflow-y: clip; |
There was a problem hiding this comment.
Is there a reason why you chose clip instead of hidden? After a quick search, clip seems to be better than hidden in terms of scrolling, which sounds good, but should be justified in the commit and PR description.
There was a problem hiding this comment.
Good point, of course there should absolutely be a justification for that! Indeed there is a strong reason why I use clip instead of hidden. As soon as you use hidden on one axis, the other axis can no longer remain visible. This was the reason why the clip option was introduced in the first place. To clip overflow of one axis while leaving the other axis unaffected.
This is exactly what this PR should do:
- Clip of the overflow on the y axis
- Keep the overflow on the x axis visible
|
Note: If this PR is merged the part marked for removal in Icinga/icinga-kubernetes-web#167 can be undone. |
Only collapse the y-axis if an collapsible item is collapsed. Additional styling in the horizontal level that overflows the x-axis should still be possible.