Skip to content

Only collapse the y-axis for collapsible elements #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrauh01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only collapse the y-axis for collapsible elements #5456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/css/icinga/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ details.collapsible:not([open]) > .collapsible-control {
// Collapsibles

.collapsible.collapsed:not(details) {
overflow: hidden;
overflow-y: clip;
Copy link
Member

@lippserd lippserd Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you chose clip instead of hidden? After a quick search, clip seems to be better than hidden in terms of scrolling, which sounds good, but should be justified in the commit and PR description.

Copy link
Contributor Author

@jrauh01 jrauh01 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, of course there should absolutely be a justification for that! Indeed there is a strong reason why I use clip instead of hidden. As soon as you use hidden on one axis, the other axis can no longer remain visible. This was the reason why the clip option was introduced in the first place. To clip overflow of one axis while leaving the other axis unaffected.

This is exactly what this PR should do:

  1. Clip of the overflow on the y axis
  2. Keep the overflow on the x axis visible

}

.collapsible.collapsed:not([data-toggle-element], details) {
Expand Down
Loading