Update Twitter username description to 'X username' + Instagram #132
Conversation
Update Twitter username description to 'X username' in desc and add instagram feed
| "instagram": { | ||
| "description": "URL to Instagram profile", | ||
| "type": "string", | ||
| "examples": [ | ||
| "https://www.instagram.com/examplespace" | ||
| ] | ||
| } |
There was a problem hiding this comment.
While I'm not a fan of Instagram at all (since the Meta takeover), I can see that some spaces might have an account. As such, it probably makes sense to add it to the schema.
| "twitter": { | ||
| "description": "Twitter username with leading <code>@</code>", | ||
| "description": "X username with leading <code>@</code>", | ||
| "type": "string", | ||
| "examples": [ | ||
| "@space_api" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
We should probably deprecate the twitter key below keymasters, it doesn't really make sense there.
What do you think, @SpaceApi/core?
There was a problem hiding this comment.
That will break backward compatibility with previous versions of the API.
There was a problem hiding this comment.
That will break backward compatibility with previous versions of the API.
Our policy is to deprecate things in version x and then remove them in x+1. The reason we have a versioned API is that we have breaking changes from time to time.
| "twitter": { | ||
| "description": "Twitter username with leading <code>@</code>", | ||
| "description": "X username with leading <code>@</code>", | ||
| "type": "string", | ||
| "examples": [ | ||
| "@space_api" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
We should also deprecate the twitter key as well and add a new x or x.com key.
3 participants
Update Twitter username description to 'X username' in desc and add instagram feed