Skip to content

Update Twitter username description to 'X username' + Instagram #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Twitter username description to 'X username' + Instagram #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions 16-draft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@
"type": "string"
},
"twitter": {
"description": "Twitter username with leading <code>@</code>",
"description": "X username with leading <code>@</code>",
"type": "string",
"examples": [
"@space_api"
Expand Down Expand Up @@ -301,7 +301,7 @@
]
},
"twitter": {
"description": "Twitter username with leading <code>@</code>",
"description": "X username with leading <code>@</code>",
"type": "string",
"examples": [
"@space_api"
Expand Down Expand Up @@ -370,6 +370,13 @@
"examples": [
"https://t.me/example-channel"
]
},
"instagram": {
"description": "URL to Instagram profile",
"type": "string",
"examples": [
"https://www.instagram.com/examplespace"
]
}
Comment on lines +374 to 380
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not a fan of Instagram at all (since the Meta takeover), I can see that some spaces might have an account. As such, it probably makes sense to add it to the schema.

}
},
Expand Down