Add parsing of 1.14.4 #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratkosrb
reviewed
Oct 21, 2023
| case ClientVersionBuild.V1_14_3_49229: | ||
| case ClientVersionBuild.V1_14_3_49821: | ||
| case ClientVersionBuild.V1_14_4_51146: | ||
| case ClientVersionBuild.V1_14_4_51535: |
Contributor
There was a problem hiding this comment.
Isn't 1.14.4 rebased upon Dragonflight? It ought to be grouped with 3.4 not with 2.5, or it won't inherit packet handlers from Dragonflight.
Member
There was a problem hiding this comment.
well 3.4.0 was SL
3.4.3 is DF.
It's a mess tbh dont mess with all the inherit packet handlers :S
Collaborator
Author
There was a problem hiding this comment.
I am doing it properly in last commit
killerwife
force-pushed
the
feature/1_14_4
branch
from
3e5e807 to
2042d23
Compare
killerwife
force-pushed
the
feature/1_14_4
branch
from
049dbc2 to
1420fe0
Compare
Collaborator
Author
|
Would really appreciate if someone could look at it and improve it or merge it. Since seems like only I and my team are using latest vanilla parsing actively. |
killerwife
force-pushed
the
feature/1_14_4
branch
from
8883ad9 to
e336875
Compare
|
The SMSG_ON_MONSTER_MOVE fix should be applied for all 1.15x builds. Already in 1.15.0 PTR build 52212 SMSG_ON_MONSTER_MOVE will not parse without the fix. |
killerwife
force-pushed
the
feature/1_14_4
branch
from
05d6de9 to
3f7414a
Compare
Collaborator
Author
|
Rebased against cata changes |
killerwife
force-pushed
the
feature/1_14_4
branch
2 times, most recently
from
658ed2b to
337c4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fields will not work and I am not going near that