Skip to content

ref: match pipeline arg name in auth views #93375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team June 11, 2025 21:02
@asottile-sentry asottile-sentry requested review from a team as code owners June 11, 2025 21:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/auth/providers/google/views.py 8.33% 11 Missing ⚠️
src/sentry/auth/providers/oauth2.py 86.66% 2 Missing ⚠️
src/sentry/auth/providers/saml2/provider.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #93375    +/-   ##
========================================
  Coverage   85.77%   85.77%            
========================================
  Files       10286    10286            
  Lines      593019   593235   +216     
  Branches    23028    23028            
========================================
+ Hits       508677   508876   +199     
- Misses      83732    83749    +17     
  Partials      610      610            

@asottile-sentry asottile-sentry merged commit 56b1fdd into master Jun 12, 2025
61 checks passed
@asottile-sentry asottile-sentry deleted the asottile-type-auth branch June 12, 2025 14:53
vishnupsatish pushed a commit that referenced this pull request Jun 12, 2025
Copy link

sentry-io bot commented Jun 12, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: FetchUser.handle() got an unexpected keyword argument 'pipeline' /auth/sso/ View Issue
  • ‼️ TypeError: FetchUser.handle() got an unexpected keyword argument 'pipeline' /auth/sso/ View Issue
  • ‼️ TypeError: FetchUser.handle() got an unexpected keyword argument 'pipeline' /auth/sso/ View Issue
  • ‼️ RecursionError: maximum recursion depth exceeded /auth/sso/ View Issue

Did you find this useful? React with a 👍 or 👎

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 12, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: a709412

getsentry-bot added a commit that referenced this pull request Jun 12, 2025
asottile-sentry added a commit that referenced this pull request Jun 17, 2025
asottile-sentry added a commit that referenced this pull request Jun 18, 2025
#93375 with fixes for auth views

<!-- Describe your PR here. -->
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
#93375 with fixes for auth views

<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants