feat(preprod): drop existing extras column on PreprodArtifact #93388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93388 +/- ##
===========================================
+ Coverage 41.27% 88.00% +46.72%
===========================================
Files 10259 10289 +30
Lines 592078 593525 +1447
Branches 23028 23028
===========================================
+ Hits 244401 522311 +277910
+ Misses 347245 70782 -276463
Partials 432 432 |
trevor-e
changed the title
|
This PR has a migration; here is the generated SQL for for --
-- Moved preprodartifact.extras field to pending deletion state
--
-- (no-op) |
trevor-e
commented
Jun 11, 2025
There was a problem hiding this comment.
Moved this other migration test to our project.
|
To clarify we have ~6 records in the table, but |
wedamija
approved these changes
Jun 12, 2025
| from sentry.testutils.cases import TestMigrations | ||
|
|
||
|
|
||
| class DropSentryJsonfieldTests(TestMigrations): |
There was a problem hiding this comment.
No need to write migration tests for table changes. These are just for backfills and so on that have logic, better to remove this since these tend to be slow and a break over time
This was referenced Jun 12, 2025
trevor-e
added a commit
that referenced
this pull request
Jun 13, 2025
Second step of the plan in #93388 Won't merge until the first PR is fully deployed.
trevor-e
added a commit
that referenced
this pull request
Jun 13, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
Second step of the plan in #93388 Won't merge until the first PR is fully deployed.
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
<!-- Describe your PR here. --> In #92056 (comment) we were requested to switch to using Django's JSONField. I don't remember anything in particular for why we chose Sentry's version, so seems fine to me! Since this is renaming a column type (text -> jsonb) this requires a few migrations ([based on this)](https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns): 1) (this PR) drop the existing column in safe mode. this is fine because we don't have any prod data for this table yet. 2) actually drop the column 3) add back the column with the new type
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Second step of the plan in #93388 Won't merge until the first PR is fully deployed.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #92056 (comment) we were requested to switch to using Django's JSONField. I don't remember anything in particular for why we chose Sentry's version, so seems fine to me!
Since this is renaming a column type (text -> jsonb) this requires a few migrations (based on this):