Skip to content

ref: detect migration drift in CI (nonblocking) #93557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tools/migrations/compare.py 0.00% 77 Missing ⚠️
tools/migrations/quick_drift_compare.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93557      +/-   ##
==========================================
+ Coverage   86.80%   88.08%   +1.28%     
==========================================
  Files       10324    10331       +7     
  Lines      594985   595336     +351     
  Branches    23126    23126              
==========================================
+ Hits       516466   524401    +7935     
+ Misses      78026    70442    -7584     
  Partials      493      493              

@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from fda5240 to 8b37792 Compare June 13, 2025 21:23
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from 8b37792 to a1961e1 Compare June 13, 2025 21:26
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from a1961e1 to 3628e7d Compare June 13, 2025 21:31
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch 2 times, most recently from b362ecd to 0bf9c4c Compare June 13, 2025 21:39
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from 0bf9c4c to 59a97c0 Compare June 13, 2025 21:46
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from 59a97c0 to 521646a Compare June 13, 2025 22:05
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from 521646a to a0fe08f Compare June 13, 2025 22:09
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from a0fe08f to f217cbb Compare June 13, 2025 22:28
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from f217cbb to c22d74c Compare June 13, 2025 22:57
@asottile-sentry asottile-sentry marked this pull request as ready for review June 13, 2025 22:57
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 13, 2025 22:57
@asottile-sentry asottile-sentry requested a review from a team June 13, 2025 22:57
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from c22d74c to abbc09e Compare June 13, 2025 22:59


def _constraint_replacement(m: re.Match[str]) -> str:
meat = m[2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meat

@asottile-sentry
Copy link
Member Author

the produced squash is flaky somehow! I'm going to try and eliminate the migration cycle with #93582 and see if that fixes the problems here (it should also significantly simplify the squash script too!)

@asottile-sentry asottile-sentry marked this pull request as draft June 15, 2025 22:21
@asottile-sentry asottile-sentry force-pushed the asottile-migration-drift-detection branch from abbc09e to d6a35de Compare June 16, 2025 16:20
@asottile-sentry asottile-sentry marked this pull request as ready for review June 16, 2025 16:40
@asottile-sentry asottile-sentry merged commit e9b814b into master Jun 16, 2025
66 checks passed
@asottile-sentry asottile-sentry deleted the asottile-migration-drift-detection branch June 16, 2025 16:42
billyvg pushed a commit that referenced this pull request Jun 18, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants