Skip to content

ref: move notifications models to a separate django app #93582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

asottile-sentry
Copy link
Member

this breaks the migration cycle between sentry<=>workflow_engine

@asottile-sentry asottile-sentry requested review from a team as code owners June 14, 2025 16:28
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0927_move_notifications_models.py src/sentry/notifications/migrations/0001_move_notifications_models.py

for 0927_move_notifications_models in sentry

--
-- Custom state/database change combination
--
-- (no-op)

for 0001_move_notifications_models in notifications

--
-- Custom state/database change combination
--
-- (no-op)

@asottile-sentry asottile-sentry enabled auto-merge (squash) June 14, 2025 16:31
@asottile-sentry
Copy link
Member Author

note that the migrations here are state-only -- I also validated with #93557 that they produce no drift \o/

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93582      +/-   ##
==========================================
- Coverage   88.01%   88.01%   -0.01%     
==========================================
  Files       10322    10324       +2     
  Lines      595057   595079      +22     
  Branches    23125    23125              
==========================================
+ Hits       523725   523737      +12     
- Misses      70839    70849      +10     
  Partials      493      493              

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0928_move_notifications_models.py src/sentry/notifications/migrations/0001_move_notifications_models.py

for 0928_move_notifications_models in sentry

--
-- Custom state/database change combination
--
-- (no-op)

for 0001_move_notifications_models in notifications

--
-- Custom state/database change combination
--
-- (no-op)

this breaks the migration cycle between sentry<=>workflow_engine
@asottile-sentry asottile-sentry force-pushed the asottile-notifications-separate-app branch from aef96e1 to f600fd8 Compare June 16, 2025 15:12
@asottile-sentry asottile-sentry merged commit bde0161 into master Jun 16, 2025
63 checks passed
@asottile-sentry asottile-sentry deleted the asottile-notifications-separate-app branch June 16, 2025 15:33
asottile-sentry added a commit that referenced this pull request Jun 16, 2025
after #93582 there are no longer
migration cycles \o/

<!-- Describe your PR here. -->
billyvg pushed a commit that referenced this pull request Jun 18, 2025
this breaks the migration cycle between sentry<=>workflow_engine

<!-- Describe your PR here. -->
billyvg pushed a commit that referenced this pull request Jun 18, 2025
after #93582 there are no longer
migration cycles \o/

<!-- Describe your PR here. -->
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
this breaks the migration cycle between sentry<=>workflow_engine

<!-- Describe your PR here. -->
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
after #93582 there are no longer
migration cycles \o/

<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants