Skip to content

ref(flags): Remove quotes around flag names in search autocomplete #93616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

ref(flags): Remove quotes around flag names in search autocomplete #93616

merged 2 commits into from
Jun 16, 2025

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jun 16, 2025 •
edited
Loading

No description provided.

@cmanallen cmanallen requested review from a team as code owners June 16, 2025 16:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 16, 2025
@cmanallen cmanallen changed the title ref(flags): Remove quotes around flag names ref(flags): Remove quotes around flag names in search autocomplete Jun 16, 2025
@cmanallen cmanallen mentioned this pull request Jun 16, 2025
Merged
aliu39
aliu39 approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be good to make a util in a follow-up, something like makeFlagSearchKey, so in the future if this syntax changes we'd only need to change it in one spot

@aliu39 aliu39 mentioned this pull request Jun 16, 2025
Closed
@cmanallen cmanallen merged commit d93434e into master Jun 16, 2025
48 checks passed
@cmanallen cmanallen deleted the cmanallen/flags-search-remove-quotes branch June 16, 2025 17:26
cmanallen added a commit that referenced this pull request Jun 16, 2025
@cmanallen
ref(flags): Remove quoted flags syntax from grammar (#93619)
2546709 
Depends on: #93616
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@cmanallen @billyvg
ref(flags): Remove quotes around flag names in search autocomplete (#…
39158cd 
…93616)
billyvg pushed a commit that referenced this pull request Jun 18, 2025
@cmanallen @billyvg
ref(flags): Remove quoted flags syntax from grammar (#93619)
69a9127 
Depends on: #93616
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@cmanallen @andrewshie-sentry
ref(flags): Remove quotes around flag names in search autocomplete (#…
2de47ff 
…93616)
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@cmanallen @andrewshie-sentry
ref(flags): Remove quoted flags syntax from grammar (#93619)
a2f3639 
Depends on: #93616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliu39 aliu39 aliu39 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @aliu39