Skip to content

chore: add compile_filter to new compiler #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chelsea-lin
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 12, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_filter branch 2 times, most recently from 01b12ba to 6f23fea Compare June 12, 2025 22:22
@chelsea-lin chelsea-lin marked this pull request as ready for review June 13, 2025 05:28
@chelsea-lin chelsea-lin requested review from a team as code owners June 13, 2025 05:28
@chelsea-lin chelsea-lin requested a review from sycai June 13, 2025 05:28
`bfcol_9` AS `bool_col`
FROM `bfcte_1`
WHERE
`bfcol_16`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm this SQL doesn't seem correct. This col ref should probably be bfcol_10. Could you double check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. This is caused by known issue fixed at #1815. We can wait for this change gets merged first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream PRs are merged so these issues are fixed.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_filter branch 2 times, most recently from 9ab5034 to b6281e2 Compare June 17, 2025 19:16
@chelsea-lin chelsea-lin requested a review from sycai June 17, 2025 19:16
@chelsea-lin chelsea-lin marked this pull request as draft June 17, 2025 21:05
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_filter branch from b6281e2 to 619d627 Compare June 20, 2025 17:59
@chelsea-lin chelsea-lin marked this pull request as ready for review June 20, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants