Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Oct 31, 2025

After removing @iexec/solidity and @iexec/interface dependencies, all tests started failing with:

Error: missing field `ast` at line 1 column 7136
  at Function.create (node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:182:37)

Hardhat failed to initialize its network provider because Solidity 0.4.11 produces a legacyAST field in the build info instead of the modern ast field.
Since Hardhat only supports the standard ast format, build-info files from Solidity 0.4.11 caused compatibility issues during deployment or testing.

Solutions Applied

  1. Updated the Solidity compiler version
  • Replaced Solidity 0.4.11 with Solidity 0.4.26, which still belongs to the 0.4.x series but generates a standard ast field that Hardhat can process correctly.
  1. Removed the custom outputSelection
  • The manual outputSelection was overriding Hardhat’s default configuration and excluded ast.
  • By removing it, Hardhat now uses its default output selection, which automatically includes the correct ast output for all source files.

… unused imports in SignatureVerifier.sol, and clean up test imports
Copilot AI review requested due to automatic review settings October 31, 2025 08:39
@Le-Caignec Le-Caignec self-assigned this Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated @iexec/solidity and @iexec/interface dependencies from the project. The main changes consolidate import statements and clean up associated TODO comments.

  • Removed @iexec/interface and @iexec/solidity packages from dependencies
  • Consolidated InitializableUpgradeabilityProxy__factory import into the main typechain imports
  • Removed obsolete commented imports and TODO comments

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Removed @iexec/interface and @iexec/solidity dependencies and associated TODO comment
test/byContract/registries/registries.test.ts Consolidated InitializableUpgradeabilityProxy__factory import from local proxy path into main typechain imports, removed TODO comment
contracts/facets/SignatureVerifier.sol Removed commented import statement for IERC1654 interface from deprecated package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 09:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Le-Caignec Le-Caignec changed the title chore: update package-lock.json and package.json dependencies, remove… feat: remove @iexec/interface & @iexec/solidity dep Oct 31, 2025
…for Solidity 0.4.11 and ensure proper build-info management
Copilot AI review requested due to automatic review settings October 31, 2025 09:37

This comment was marked as spam.

Copilot AI review requested due to automatic review settings October 31, 2025 09:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 11:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 11:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (a66516e) to head (cab6c6e).

Additional details and impacted files
@@               Coverage Diff               @@
##           feat/clean-dep     #310   +/-   ##
===============================================
  Coverage           90.08%   90.08%           
===============================================
  Files                  38       38           
  Lines                1230     1230           
  Branches              244      244           
===============================================
  Hits                 1108     1108           
  Misses                122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Le-Caignec Le-Caignec marked this pull request as ready for review October 31, 2025 13:34
{ version: '0.4.11', settings }, // RLC contracts
{ version: '0.8.21', settings: v8Settings }, // PoCo contracts
{ version: '0.6.12', settings }, // External dependencies (@amxx/factory)
{ version: '0.4.26', settings }, // RLC contracts - 0.4.26 is the minimum version that produces standard AST output required for storage layout checks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from 0.4.11 to 0.4.26: produces a standard ‘ast’ output

enabled: true,
runs: 200,
},
outputSelection: { '*': { '*': ['storageLayout'] } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents Hardhat from producing an ast in the build files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants