-
Notifications
You must be signed in to change notification settings - Fork 14
feat: remove @iexec/interface & @iexec/solidity dep
#310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/clean-dep
Are you sure you want to change the base?
Conversation
… unused imports in SignatureVerifier.sol, and clean up test imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated @iexec/solidity and @iexec/interface dependencies from the project. The main changes consolidate import statements and clean up associated TODO comments.
- Removed
@iexec/interfaceand@iexec/soliditypackages from dependencies - Consolidated
InitializableUpgradeabilityProxy__factoryimport into the main typechain imports - Removed obsolete commented imports and TODO comments
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed @iexec/interface and @iexec/solidity dependencies and associated TODO comment |
| test/byContract/registries/registries.test.ts | Consolidated InitializableUpgradeabilityProxy__factory import from local proxy path into main typechain imports, removed TODO comment |
| contracts/facets/SignatureVerifier.sol | Removed commented import statement for IERC1654 interface from deprecated package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…and add clean build artifacts step in CI workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@iexec/interface & @iexec/solidity dep
… ensure recompilation before deployment
…for Solidity 0.4.11 and ensure proper build-info management
…simplifying build commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…4.26 to address legacyAST issues
…rify AST output format
…lect PoCo contracts and clarify external dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/clean-dep #310 +/- ##
===============================================
Coverage 90.08% 90.08%
===============================================
Files 38 38
Lines 1230 1230
Branches 244 244
===============================================
Hits 1108 1108
Misses 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { version: '0.4.11', settings }, // RLC contracts | ||
| { version: '0.8.21', settings: v8Settings }, // PoCo contracts | ||
| { version: '0.6.12', settings }, // External dependencies (@amxx/factory) | ||
| { version: '0.4.26', settings }, // RLC contracts - 0.4.26 is the minimum version that produces standard AST output required for storage layout checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from 0.4.11 to 0.4.26: produces a standard ‘ast’ output
| enabled: true, | ||
| runs: 200, | ||
| }, | ||
| outputSelection: { '*': { '*': ['storageLayout'] } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents Hardhat from producing an ast in the build files.
After removing
@iexec/solidityand@iexec/interfacedependencies, all tests started failing with:Hardhat failed to initialize its network provider because Solidity 0.4.11 produces a legacyAST field in the build info instead of the modern
astfield.Since Hardhat only supports the standard
astformat, build-info files from Solidity 0.4.11 caused compatibility issues during deployment or testing.Solutions Applied
ast.astoutput for all source files.