Skip to content

feat: remove @iexec/interface & @iexec/solidity dep #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: feat/clean-dep
Choose a base branch
from
+6,121 −17,932
Open

feat: remove @iexec/interface & @iexec/solidity dep #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
356b2b7
chore: update package-lock.json and package.json dependencies, remove…
Le-Caignec Oct 30, 2025
5636152
chore: comment out outputSelection in hardhat.config.ts for clarity
Le-Caignec Oct 31, 2025
7abbd55
chore: remove outputSelection from hardhat.config.ts to use defaults …
Le-Caignec Oct 31, 2025
9a9f626
chore: update CI workflows to clean build artifacts, force build, and…
Le-Caignec Oct 31, 2025
b87f41d
chore: update hardhat.config.ts and CI workflows to handle legacyAST …
Le-Caignec Oct 31, 2025
0557cb6
chore: streamline CI workflows by removing redundant clean steps and …
Le-Caignec Oct 31, 2025
6818506
fix rollback
Le-Caignec Oct 31, 2025
3c7251d
chore: update Solidity version in hardhat.config.ts from 0.4.11 to 0.…
Le-Caignec Oct 31, 2025
f70e6c1
chore: update comment for Solidity 0.4.26 in hardhat.config.ts to cla…
Le-Caignec Oct 31, 2025
7102dfa
chore: update comment for Solidity 0.8.21 in hardhat.config.ts to ref…
Le-Caignec Oct 31, 2025
f513a88
chore: add check to skip rlc-faucet-contract in storage layout compat…
Le-Caignec Oct 31, 2025
ae7d84a
chore: add RLC.sol to dependencyCompiler paths in hardhat.config.ts
Le-Caignec Oct 31, 2025
a5b8e5e
Update scripts/check-storage.ts
Le-Caignec Oct 31, 2025
cab6c6e
Update hardhat.config.ts
Le-Caignec Oct 31, 2025
6210d9d
Merge branch 'feat/clean-dep' into feat/remove-useless-dep
Le-Caignec Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ concurrency:
cancel-in-progress: true

jobs:
# TODO extract common steps into reusable workflows to resolve
# concurrency issue.
# TODO extract common steps into reusable workflows to resolve
# concurrency issue.
build-and-test:
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 0 additions & 1 deletion contracts/facets/SignatureVerifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ pragma solidity ^0.8.0;

import {IERC734} from "../external/interfaces/IERC734.sol";
import {IERC1271} from "@openzeppelin/contracts/interfaces/IERC1271.sol";
// import "@iexec/solidity/contracts/ERC1654/IERC1654.sol";
import {PocoStorageLib} from "../libs/PocoStorageLib.sol";
import {FacetBase} from "./FacetBase.sol";
import {MessageHashUtils} from "@openzeppelin/contracts/utils/cryptography/MessageHashUtils.sol";
Expand Down
7 changes: 3 additions & 4 deletions hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const settings = {
enabled: true,
runs: 200,
},
outputSelection: { '*': { '*': ['storageLayout'] } },
Copy link
Contributor

@gfournieriExec gfournieriExec Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this ?

Copy link
Contributor Author

@Le-Caignec Le-Caignec Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents Hardhat from producing an ast in the build files.

};

const v8Settings = {
Expand All @@ -76,9 +75,9 @@ const v8Settings = {
const config: HardhatUserConfig = {
solidity: {
compilers: [
{ version: '0.8.21', settings: v8Settings }, // PoCo Boost
{ version: '0.6.12', settings }, // PoCo contracts
{ version: '0.4.11', settings }, // RLC contracts
{ version: '0.8.21', settings: v8Settings }, // PoCo contracts
{ version: '0.6.12', settings }, // External dependencies (@amxx/factory)
{ version: '0.4.26', settings }, // RLC contracts - 0.4.26 is the minimum version that produces standard AST output required for storage layout checks
Copy link
Contributor Author

@Le-Caignec Le-Caignec Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from 0.4.11 to 0.4.26: produces a standard ‘ast’ output

],
},
namedAccounts: {
Expand Down
Loading