fix: add check for nested empty JSON objects #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
commented
Jun 30, 2025
|
|
||
| if (entry.value.kind == JSONValueKind.OBJECT) { | ||
| const object = entry.value.toObject(); | ||
| for (let i = 0; i < object.entries.length; i++) { |
Contributor
Author
There was a problem hiding this comment.
This for loop is a mistake. We shouldn’t keep it, I think.
Contributor
There was a problem hiding this comment.
ok, I don't have the history of this
Contributor
Author
There was a problem hiding this comment.
no i think it's an issue
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug that causes rendering issues when encountering empty JSON objects by adding a check to prevent unnecessary recursive parsing.
- Removes a redundant loop over object entries and adds a condition to check for non-empty objects before recursion.
- Improves both the clarity and efficiency of the recursive parsing function.
zguesmi
approved these changes
Jun 30, 2025
… improved test setup
Le-Caignec
commented
Jun 30, 2025
Comment on lines
+8
to
+10
| runs-on: | ||
| group: Azure_runners | ||
| labels: [ self-hosted, Linux, X64 ] |
Contributor
Author
There was a problem hiding this comment.
We need runner connected to iexec infra to make deployment
| it('should work as expected', async () => { | ||
| // --- GIVEN | ||
| const dataProtector = new IExecDataProtector(); | ||
| const dataProtector = new IExecDataProtector(...getTestConfig()); |
Contributor
Author
There was a problem hiding this comment.
This was connected to the production subgraph, causing the test to fail.
…nce; update test to reflect changes in expected output
…r expected schema output
Le-Caignec
commented
Jun 30, 2025
PierreJeanjacquot
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is designed to parse the JSON schema emitted on-chain and display it in the subgraph. Like that :
Bug Description
The issue arises when some fields in the schema contain an empty JSON object (e.g.,
"field":{}). These cases are not currently handled properly and result in a rendering/display bug.Fix Summary
This fix addresses the issue by correctly handling fields with empty JSON objects, ensuring the schema is displayed as expected.