-
Notifications
You must be signed in to change notification settings - Fork 10
fix: add check for nested empty JSON objects #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0c7e8f7
fix: add check for empty objects in recursiveParse function
Le-Caignec fe631ef
fix: update protectData test to include size and emptyObject in binar…
Le-Caignec 449b21a
test: add case for handling nested empty JSON objects in getProtected…
Le-Caignec 1a30d72
fix: format code
Le-Caignec 5946303
fix: update IExecDataProtector instantiation to use getTestConfig for…
Le-Caignec 1242b3a
fix: update deploy job to use Azure runners for improved environment …
Le-Caignec b2bfa53
test: unit test reverseSafeSchema
PierreJeanjacquot f5e9b68
test: schema with multiple keys in nested object
PierreJeanjacquot 75dc32e
fix: refactor reverseSafeSchema for improved readability and performa…
Le-Caignec 69c179c
test: fix bad test data
PierreJeanjacquot ac0290e
fix: update reverseSafeSchema to assign type directly; adjust test fo…
Le-Caignec fc8e49a
test: use real data
PierreJeanjacquot 5afaedc
Update .github/workflows/deploy-subgraph.yml
Le-Caignec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| import { describe, it, expect } from '@jest/globals'; | ||
| import { IExecDataProtector } from '../../src/index.js'; | ||
| import { getTestConfig } from '../test-utils.js'; | ||
|
|
||
| describe('When instantiating SDK without a signer', () => { | ||
| describe('When calling a read method', () => { | ||
| it('should work as expected', async () => { | ||
| // --- GIVEN | ||
| const dataProtector = new IExecDataProtector(); | ||
| const dataProtector = new IExecDataProtector(...getTestConfig()); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was connected to the production subgraph, causing the test to fail. |
||
|
|
||
| // --- WHEN/THEN | ||
| await expect( | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need runner connected to iexec infra to make deployment