fix: could not cancel the unintialized download #6867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds event emission for download abortion to notify listeners when a model download is stopped. The change emits a DownloadEvent.onFileDownloadStopped event in the abortDownload method's finally block to ensure consistent notification of download state changes.
- Imports
eventsandDownloadEventfrom@janhq/core - Modifies
abortDownloadto emit an event after aborting the download
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
louis-jan
force-pushed
the
fix/model-download-hang
branch
from
0e68dc2 to
eb1722b
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
urmauur
approved these changes
Nov 3, 2025
Barecheck - Code coverage reportTotal: 30.01%Your code coverage diff: 0.02% ▴ Uncovered files and lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR fixes model download hang issue, as soon as model failed to download due to network issue, it hangs and does not let users to cancel it. This also improves cancel button where it responses immediately.
This PR also fixed the issue where it could not open app folder on mac from settings
Screen.Recording.2025-11-03.at.20.12.51.mov
Fixes Issues
Self Checklist