Fix API generation for v1.20 (rc.0) #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StorageVersion resource introduced is not a good citizen:
- resource API version named: `internal.apiserver.k8s.io`
- definition path in Swagger: `io.k8s.api.apiserverinternal`
- operation ID defined as: `createInternalApiserver...`
That is, the two key words ("internal" and "apiserver") are in different
order; sometimes they split, other times they are merged.
The following APIs are not RESTful APIs because they are not associated
with any REST resources. These two APIs have to be skipped.
- `getServiceAccountIssuerOpenIDConfiguration` exposed at
`/.well-known/openid-configuration/`;
- `getServiceAccountIssuerOpenIDKeyset` exposed at `/openid/v1/jwks`.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
This was referenced Dec 3, 2020
|
Changes look good. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems in the API reference generator:
StorageVersionresource introduced in 1.20 is not a good citizen:internal.apiserver.k8s.ioio.k8s.api.apiserverinternalcreateInternalApiserver...Note that the two key words ("internal" and "apiserver") are in different orders; sometimes they split, other times they are merged.
getServiceAccountIssuerOpenIDConfigurationexposed at/.well-known/openid-configuration/;getServiceAccountIssuerOpenIDKeysetexposed at/openid/v1/jwks.closes: #178