Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

  • Update MINIMUM_GIT_VERSION constant from 2.20.0 to 2.35.0 in getRepoState.ts
  • Add ensureMinimumGitVersion check to spawnGitAsync helper when it returns non-zero exit code
  • Use deep imports for Executable and FileSystem from node-core-library
  • Verify the changes are correct and minimal
  • Run build to ensure no compilation errors
  • Run tests to ensure nothing breaks
  • Request code review (no issues found)
  • Run security scan (no vulnerabilities found)
Original prompt

Update the MINIMUM_GIT_VERSION constant in package-deps-hash/src/getRepoState.ts to 2.35.0 to account for the usage of the --format argument to git ls-files.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update MINIMUM_GIT_VERSION constant to 2.35.0 Update MINIMUM_GIT_VERSION to 2.35.0 for git ls-files --format support Dec 17, 2025
Copilot AI requested a review from dmichon-msft December 17, 2025 00:08
@dmichon-msft
Copy link
Contributor

@copilot Also split the import from @rushstack/node-core-library in this file to use deep imports (i.e. from /lib/Executable and /lib/FileSystem) for the value imports.

Copy link
Contributor Author

Copilot AI commented Dec 17, 2025

@copilot Also split the import from @rushstack/node-core-library in this file to use deep imports (i.e. from /lib/Executable and /lib/FileSystem) for the value imports.

Done. Split the imports to use deep imports from @rushstack/node-core-library/lib/Executable and @rushstack/node-core-library/lib/FileSystem in commit 50fb32c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

2 participants