Skip to content

Update MINIMUM_GIT_VERSION to 2.35.0 for git ls-files --format support #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −2
Draft

Update MINIMUM_GIT_VERSION to 2.35.0 for git ls-files --format support #5508

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6959dd4
Initial plan
Copilot Dec 16, 2025
2651f61
Update plan to include ensureMinimumGitVersion check in spawnGitAsync
Copilot Dec 16, 2025
effa006
Add ensureMinimumGitVersion check to spawnGitAsync helper
Copilot Dec 17, 2025
50fb32c
Use deep imports for Executable and FileSystem from node-core-library
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libraries/package-deps-hash/src/getRepoState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import type * as child_process from 'node:child_process';
import { once } from 'node:events';
import { Readable, pipeline } from 'node:stream';

import { Executable, FileSystem, type IExecutableSpawnOptions } from '@rushstack/node-core-library';
import { Executable, type IExecutableSpawnOptions } from '@rushstack/node-core-library/lib/Executable';
import { FileSystem } from '@rushstack/node-core-library/lib/FileSystem';

export interface IGitVersion {
major: number;
Expand All @@ -15,7 +16,7 @@ export interface IGitVersion {

const MINIMUM_GIT_VERSION: IGitVersion = {
major: 2,
minor: 20,
minor: 35,
patch: 0
};

Expand Down Expand Up @@ -309,6 +310,8 @@ async function spawnGitAsync(

const [status] = await once(proc, 'close');
if (status !== 0) {
ensureGitMinimumVersion(gitPath);

throw new Error(`git ${args[0]} exited with code ${status}:\n${stderr}`);
}

Expand Down