Skip to content

Refactor FXIOS-27321 [TA 2025] Move sharesheet panel probes to its own YAML file #27477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

Refactor FXIOS-27321 [TA 2025] Move sharesheet panel probes to its own YAML file #27477

merged 2 commits into from
Jun 23, 2025

Conversation

utsavDave97
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR separates the sharesheet panel probes into their own specification file and adds a corresponding tag.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@utsavDave97 utsavDave97 requested a review from a team as a code owner June 20, 2025 22:43
@utsavDave97 utsavDave97 requested a review from yoanarios June 20, 2025 22:43
ih-codes
ih-codes approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@ih-codes ih-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jun 20, 2025 •
edited
Loading

Messages
📖 Edited 4 files
📖 Created 1 files

Generated by 🚫 Danger Swift against a547469

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 21, 2025

This pull request has conflicts when rebasing. Could you fix it @utsavDave97? 🙏

@utsavDave97 utsavDave97 requested a review from ih-codes June 21, 2025 13:37
@ih-codes ih-codes merged commit cca0849 into mozilla-mobile:main Jun 23, 2025
8 checks passed
@utsavDave97 utsavDave97 deleted the FXIOS-27321-sharesheet-metrics-yaml branch June 25, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoanarios yoanarios yoanarios approved these changes

@ih-codes ih-codes Awaiting requested review from ih-codes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utsavDave97 @mobiletest-ci-bot @yoanarios @ih-codes