Skip to content

Refactor FXIOS-27321 [TA 2025] Move sharesheet panel probes to its own YAML file #27477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firefox-ios/Client/Glean/gleanProbes.xcfilelist
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ $(PROJECT_DIR)/Client/Glean/probes/metrics.yaml
$(PROJECT_DIR)/Client/Glean/probes/microsurvey.yaml
$(PROJECT_DIR)/Client/Glean/probes/reader_mode.yaml
$(PROJECT_DIR)/Client/Glean/probes/settings.yaml
$(PROJECT_DIR)/Client/Glean/probes/share_sheet.yaml
$(PROJECT_DIR)/Client/Glean/probes/tabs_panel.yaml
$(PROJECT_DIR)/Client/Glean/probes/toast.yaml
$(PROJECT_DIR)/Client/Glean/probes/toolbar.yaml
1 change: 1 addition & 0 deletions firefox-ios/Client/Glean/glean_index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ metrics_files:
- firefox-ios/Client/Glean/probes/microsurvey.yaml
- firefox-ios/Client/Glean/probes/reader_mode.yaml
- firefox-ios/Client/Glean/probes/settings.yaml
- firefox-ios/Client/Glean/probes/share_sheet.yaml
- firefox-ios/Client/Glean/probes/tabs_panel.yaml
- firefox-ios/Client/Glean/probes/toast.yaml
- firefox-ios/Client/Glean/probes/toolbar.yaml
Expand Down
38 changes: 0 additions & 38 deletions firefox-ios/Client/Glean/probes/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3377,44 +3377,6 @@ urlbar:
- [email protected]
expires: "2026-01-01"

# Share sheet specific metrics

share_sheet:
shared_to:
type: event
description: |
Event to record that the user has shared content via the ShareManager.
bugs:
- https://github.com/mozilla-mobile/firefox-ios/issues/23704
data_reviews:
- https://github.com/mozilla-mobile/firefox-ios/pull/23786
notification_emails:
- [email protected]
expires: "2026-01-01"
extra_keys:
activity_identifier:
type: string
description: |
The activity identifier indicating to where the user shared content.
share_type:
type: string
description: |
The type of content shared. Either a file, website, or tab.
has_share_message:
type: boolean
description: |
Whether an explicit share message (and optional subject line) was
appended to the shared content.
is_enrolled_in_sent_from_firefox:
type: boolean
description: |
Whether the user is enrolled in the Sent from Firefox experiment.
is_opted_in_sent_from_firefox:
type: boolean
description: |
Whether the user is opted in to the Sent from Firefox experiment.
Only returns true if the user is both enrolled and opted in.

# Share related metrics

share:
Expand Down
58 changes: 58 additions & 0 deletions firefox-ios/Client/Glean/probes/share_sheet.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

# This file defines the metrics that are recorded by the Glean SDK. They are
# automatically converted to Swift code at build time using the `glean_parser`
# PyPI package.

# This file is organized (roughly) alphabetically by metric names
# for easy navigation

---
$schema: moz://mozilla.org/schemas/glean/metrics/2-0-0

$tags:
- ShareSheet

###############################################################################
# Documentation
###############################################################################

# Add your new metrics and/or events here.
# Share sheet specific metrics
share_sheet:
shared_to:
type: event
description: |
Event to record that the user has shared content via the ShareManager.
bugs:
- https://github.com/mozilla-mobile/firefox-ios/issues/23704
data_reviews:
- https://github.com/mozilla-mobile/firefox-ios/pull/23786
notification_emails:
- [email protected]
expires: "2026-01-01"
extra_keys:
activity_identifier:
type: string
description: |
The activity identifier indicating to where the user shared content.
share_type:
type: string
description: |
The type of content shared. Either a file, website, or tab.
has_share_message:
type: boolean
description: |
Whether an explicit share message (and optional subject line) was
appended to the shared content.
is_enrolled_in_sent_from_firefox:
type: boolean
description: |
Whether the user is enrolled in the Sent from Firefox experiment.
is_opted_in_sent_from_firefox:
type: boolean
description: |
Whether the user is opted in to the Sent from Firefox experiment.
Only returns true if the user is both enrolled and opted in.
3 changes: 3 additions & 0 deletions firefox-ios/Client/Glean/tags.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ ReadingListPanel:
Settings:
description: Corresponds to all the options encompassed in the app's settings screens.

ShareSheet:
description: Corresponds to the iOS system share sheet for sharing content out of the app.

TabsPanel:
description: Corresponds to all things related to the tab panel.

Expand Down