json compatible output printing #414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 90.11% 89.39% -0.72%
==========================================
Files 40 57 +17
Lines 4066 4339 +273
Branches 744 753 +9
==========================================
+ Hits 3664 3879 +215
- Misses 256 289 +33
- Partials 146 171 +25
|
| write(']') | ||
| else: | ||
| value = repr(obj) | ||
| value = '%s' % obj |
Owner
There was a problem hiding this comment.
This change will return __str__ instead of __repr__. Is that correct?
| write('\n') | ||
| else: | ||
| write(value) | ||
| write('"%s"' % value) |
Owner
There was a problem hiding this comment.
Are double quotes escaped properly here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to output printing makes it easier to load the resulting data with JSON parsers