Skip to content

json compatible output printing #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

json compatible output printing #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/zeep/xsd/printer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def _format(self, obj, stream, indent=4, level=1):
if num > 0:
for i, (key, value) in enumerate(obj.items()):
write(' ' * (indent * level))
write("'%s'" % key)
write('"%s"' % key)
write(': ')
self._format(value, stream, level=level + 1)
if i < num - 1:
Expand All @@ -53,7 +53,7 @@ def _format(self, obj, stream, indent=4, level=1):
write(' ' * (indent * (level - 1)))
write(']')
else:
value = repr(obj)
value = '%s' % obj
Copy link
Owner

@mvantellingen mvantellingen Apr 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will return __str__ instead of __repr__. Is that correct?

if '\n' in value:
lines = value.split('\n')
num = len(lines)
Expand All @@ -64,4 +64,4 @@ def _format(self, obj, stream, indent=4, level=1):
if i < num - 1:
write('\n')
else:
write(value)
write('"%s"' % value)
Copy link
Owner

@mvantellingen mvantellingen Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are double quotes escaped properly here?

18 changes: 17 additions & 1 deletion tests/test_pprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json
from zeep.xsd import printer


def test_dict():
pprint = printer.PrettyPrinter()
data = {
Expand Down Expand Up @@ -32,3 +32,19 @@ def test_list():
},
]
pprint.pformat(data)


def test_json_load():
pprint = printer.PrettyPrinter()
data = [
{
'foo': 'bar',
'foo_2': 'bar',
},
{
'foo': 'bar',
'foo_2': 'bar',
},
]
json.loads(pprint.pformat(data))