feat(gh_actions_ls): add vim.lsp.config support

[chrisgrieser]

gh_actions_ls is missing in the lsp folder, likely due to it using a workaround with single file support to prevent it from attaching to every yaml file, even though it should only attach to certain yaml files, without defining an extra yaml.github filetype (see #3558).

Using .github/workflows and co as root_markers however prevents this issue, allowing us to use the LSP like a regular LSP without it attaching to unrelated yaml files. Thus, there is no problem anymore using git_actions_ls with vim.lsp.config.

cc @disrupted

[justinmk]

Nice, thanks! So we can cross this from #3705

[gstokkink]

Just a headsup, this LSP config did not work for me until I also added the following to the config:

          init_options = {
            sessionToken = <whatever>
          },

Maybe that needs to be documented?

Also, diagnostic error messages don't show up, but maybe there's something broken in my setup, though this only occurs for this particular LSP as far as I can see.

[chrisgrieser]

@gstokkink That's weird, when I tested it earlier, it seemed to work. But I can confirm I now also get the error, and diagnostics not showing up anymore. I am not sure what causes this behavior though, vim.lsp.config and lspconfig[server].setup should be mostly equivalent?

[justinmk]

vim.lsp.config and lspconfig[server].setup should be mostly equivalent?

yes. and I don't see how init_options could be related to their differences anyway.

does the old config still work? maybe something changes in the LS.

[gstokkink]

Weird thing is that sometimes the diagnostics do show up, but I haven't yet figured out what causes this erratic behaviour. Maybe some caching issue?

[justinmk]

Reminds me of neovim/neovim#32247

Maybe neovim/neovim#33391 (comment) provides a hint that could be used here?

[gstokkink]

Alright, fixed it. I had to set 'event' to VeryLazy instead of LspAttach for the diagnostic plugin I use: https://github.com/rachartier/tiny-inline-diagnostic.nvim. Point about the sessionToken still stands, however.

[justinmk]

A small update to the docstring would be welcome

[chrisgrieser]

Aside from the session-token issue, the LS still attaches to some yaml files it's not supposed to attach. I am very sorry, I assume I messed up my testing of the change by somehow still running lspconfig[server].setup instead of vim.lsp.config.

[gstokkink]

Yeah, I noticed it attaching to other YAML files as well. Not sure how this can happen, are the root markers not being evaluated correctly?

[justinmk]

Look at the old config, and figure out how to make it work with the new one.

[chrisgrieser]

@gstokkink

Yeah that one is due to the vim.lsp.config not supporting "disabling" single file mode. nvim 0.11.1 (or nightly riht now) will support workspace_required = true, which I just added via PR.

[gstokkink]

@chrisgrieser thanks! I've resorted to using the yaml.github workaround in the meantime 🙂

[jhoogstraat]

The issue is not so much the sessionToken, but init_options not being present:
https://github.com/actions/languageservices/blob/e2ec264801c7166e011b35424de4dc0a2aa33811/languageserver/src/connection.ts#L54

Here they access options.sessionToken, but options is nil by default.

[chrisgrieser]

@gstokkink @jhoogstraat
I made a PR which should fix both issues, if you want to have a look: #3857