Skip to content

fix(gh_actions_ls): use root_dir and add init_options #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

chrisgrieser
Copy link
Contributor

@chrisgrieser chrisgrieser commented May 19, 2025

  1. Replace root_markers and workspace_required = true with a root_dir function that checks the file is located in the correct location. This prevents some edge cases where the LSP would still attach to non-workflow files. This also makes unnecessary to use a yaml.github filetype, as the readme of the lsp describes.
  2. add an empty init_options table, since such a table is apparently needed by the LSP: feat(gh_actions_ls): add vim.lsp.config support #3713 (comment)

@justinmk justinmk merged commit 71be9bb into neovim:master May 21, 2025
10 checks passed
@gstokkink
Copy link

Could we get a new release for this and other LSP fixes? Been a month since the last release, though I don't know how stable the master branch is at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants