Skip to content

Conversation

@bchess
Copy link
Contributor

@bchess bchess commented Jul 21, 2019

setup.py's build does an actual compilation of mujoco-py, which has dependencies. These are thus build dependencies, not just install dependencies. Right now, oftentimes when doing pip install mujoco-py, this build fails and the compilation doesn't occur until actual first runtime import.

PEP518 describes the pyproject.toml file used to declare build dependencies. This adds that file, fixing the behavior to compile mujoco-py during pip install.

@bchess bchess requested a review from aray-openai July 21, 2019 20:31
@MillionIntegrals
Copy link
Contributor

Looks good, one question: do setuptools/pip automatically process pyproject.toml or is it more of an information for users?

@MillionIntegrals MillionIntegrals self-requested a review August 12, 2019 20:51
Copy link
Contributor

@MillionIntegrals MillionIntegrals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bchess
Copy link
Contributor Author

bchess commented Aug 12, 2019

Looks good, one question: do setuptools/pip automatically process pyproject.toml or is it more of an information for users?

It automatically uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants