add test and support for odd-sized textures #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welinder
approved these changes
Jul 12, 2017
Contributor
welinder
left a comment
welinder
left a comment
There was a problem hiding this comment.
Thanks for fixing! One quick question in the comments.
Also worth a version bump.
| modder.set_rgb('g3', (0, 0, 255)) | ||
| modder.set_rgb('g4', (255, 0, 255)) | ||
| compare_imgs(sim.render(200, 200, camera_name="topcam"), | ||
| compare_imgs(sim.render(201, 205, camera_name="topcam"), |
Contributor
There was a problem hiding this comment.
hmm, the issue was with texture sizes, not render buffer sizes, right? why do we need to change these test images?
Contributor
Author
There was a problem hiding this comment.
we don't! happy to change them back if you want.
in any case the test images need to be regenerated.
Contributor
Author
There was a problem hiding this comment.
I would add that i think its slightly better coverage to have width != height and to have odd numbers.
Contributor
There was a problem hiding this comment.
yep, makes sense. let's go with these new images!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.