Skip to content

Conversation

@disksing
Copy link
Collaborator

What problem does this PR solve?

In our severless use case, sometimes tiproxy may connect to the wrong tidb (other user's instance). In this case, we hope that tiproxy can automatically reconnect for certain specific error types, instead of returning the errors to the client.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: disksing <[email protected]>
@disksing disksing requested review from djshow832 and xhebox October 30, 2023 03:56
@ti-chi-bot ti-chi-bot bot requested a review from bb7133 October 30, 2023 03:56
@ti-chi-bot ti-chi-bot bot added the size/M label Oct 30, 2023
Signed-off-by: disksing <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 06:21:33.521797147 +0000 UTC m=+2847691.108907291: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 30, 2023
@djshow832
Copy link
Collaborator

/retest

@disksing
Copy link
Collaborator Author

/test pull-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit c9c5817 into pingcap:main Oct 30, 2023
@disksing disksing deleted the disksing/replay-handshake branch October 31, 2023 02:29
@xhebox xhebox mentioned this pull request Nov 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants