Skip to content

Conversation

@YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #952

Problem Summary:

Previously, a malformed packet will cause panic (though in recoverable goroutine). It'll increase metrics.ServerErrCounter.WithLabelValues("panic") and cause some alerts.

What is changed and how it works:

I checked that the length of the handshake response packet (or ssl request packet) should be greater or equal than 32, so some of the malformed packet will be refused.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 October 23, 2025 07:41
@ti-chi-bot ti-chi-bot bot added the size/M label Oct 23, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@5a50d72). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #956   +/-   ##
=======================================
  Coverage        ?   67.60%           
=======================================
  Files           ?      136           
  Lines           ?    13479           
  Branches        ?        0           
=======================================
  Hits            ?     9112           
  Misses          ?     3739           
  Partials        ?      628           
Flag Coverage Δ
unit 67.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 23, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-23 09:58:44.63502572 +0000 UTC m=+952230.712278270: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 24809d0 into pingcap:main Oct 23, 2025
6 checks passed
@YangKeao
Copy link
Member Author

/cherry-pick release-nextgen-20251023

@ti-chi-bot
Copy link
Member

@YangKeao: new pull request created to branch release-nextgen-20251023: #958.

In response to this:

/cherry-pick release-nextgen-20251023

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic in (auth *Authenticator) handshakeFirstTime

4 participants