Skip to content

[React-Native][New Arch] Fix extra rerenders of the GLView on updating parent View pan getsture handlers and pointerEvents props #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[React-Native][New Arch] Fix extra rerenders of the GLView on updating parent View pan getsture handlers and pointerEvents props #3539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/fiber/src/native/Canvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function CanvasImpl({
onPointerMissed,
onCreated,
ref,
pointerEvents,
...props
}: CanvasProps) {
// Create a known catalogue of Threejs-native elements
Expand Down Expand Up @@ -224,10 +225,11 @@ function CanvasImpl({
}, [canvas])

return (
<_View {...props} ref={viewRef} onLayout={onLayout} style={{ flex: 1, ...style }} {...bind}>
<_View {...props} ref={viewRef} onLayout={onLayout} style={{ flex: 1, ...style }}>
{width > 0 && (
<GLView msaaSamples={antialias ? 4 : 0} onContextCreate={onContextCreate} style={StyleSheet.absoluteFill} />
)}
<_View style={StyleSheet.absoluteFill} pointerEvents={pointerEvents} {...bind} />
</_View>
)
}
Expand Down
Loading