refactor(utilities): refactoring Utilities constants #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssi02014
commented
Aug 9, 2023
…-parser into refac/utilities
…act-parser into refac/utilities
ssi02014
commented
Aug 9, 2023
Comment on lines
+48
to
+69
|
|
||
| var RESERVED_SVG_MATHML_ELEMENTS = new Set([ | ||
| 'annotation-xml', | ||
| 'color-profile', | ||
| 'font-face', | ||
| 'font-face-src', | ||
| 'font-face-uri', | ||
| 'font-face-format', | ||
| 'font-face-name', | ||
| 'missing-glyph' | ||
| ]); | ||
|
|
||
| function isCustomComponent(tagName, props) { | ||
| if (tagName.indexOf('-') === -1) { | ||
| return props && typeof props.is === 'string'; | ||
| } | ||
|
|
||
| switch (tagName) { | ||
| // These are reserved SVG and MathML elements. | ||
| // We don't mind this whitelist too much because we expect it to never grow. | ||
| // The alternative is to track the namespace in a few places which is convoluted. | ||
| // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts | ||
| case 'annotation-xml': | ||
| case 'color-profile': | ||
| case 'font-face': | ||
| case 'font-face-src': | ||
| case 'font-face-uri': | ||
| case 'font-face-format': | ||
| case 'font-face-name': | ||
| case 'missing-glyph': | ||
| return false; | ||
| default: | ||
| return true; | ||
| // These are reserved SVG and MathML elements. | ||
| // We don't mind this whitelist too much because we expect it to never grow. | ||
| // The alternative is to track the namespace in a few places which is convoluted. | ||
| // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts | ||
| if (RESERVED_SVG_MATHML_ELEMENTS.has(tagName)) { | ||
| return false; |
There was a problem hiding this comment.
I worked similarly to the existing "elementsWithNoTextChildren" approach. 🙏
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 177 169 -8
Branches 59 50 -9
=========================================
- Hits 177 169 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@remarkablemark |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Hello 👋, @remarkablemark
I worked on refactoring by isolating code that could be managed by constants inside the
utilities.js.Please review this pull request to see if it's appropriate. 🙏
What is the current behavior?
There is no change in behavior.
What is the new behavior?
There is no change in behavior.
Checklist: