Skip to content

Detect if conflicting default rmw implementations have been specified #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2016
Merged

Detect if conflicting default rmw implementations have been specified #11

merged 3 commits into from
Apr 16, 2016

Conversation

@dhood
Copy link
Member

@dhood dhood commented Apr 15, 2016

raised from discussion in #10

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Apr 15, 2016
@dhood dhood mentioned this pull request Apr 15, 2016
Closed
@wjwwood
Copy link
Member

wjwwood commented Apr 15, 2016

lgtm, I think that will prevent most people from having the wrong expectation when using the RMW_IMPLEMENATION CMake/env vars to pick the default.

@wjwwood
Copy link
Member

wjwwood commented Apr 15, 2016

@dhood can you run CI over this, at least on Linux just to make sure we don't break master?

@dhood
Copy link
Member Author

dhood commented Apr 15, 2016

ok I will

On Fri, Apr 15, 2016 at 1:59 PM, William Woodall [email protected]
wrote:

@dhood https://github.com/dhood can you run CI over this, at least on
Linux just to make sure we don't break master?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#11 (comment)

@dhood dhood force-pushed the default-rmw-implementation branch from 526d8d2 to 78e2bde Compare April 15, 2016 23:02
@dhood dhood force-pushed the default-rmw-implementation branch from 78e2bde to c8e1d0e Compare April 15, 2016 23:44
@dhood dhood force-pushed the default-rmw-implementation branch from c8e1d0e to 4f7a562 Compare April 16, 2016 00:18
@dhood
Copy link
Member Author

dhood commented Apr 16, 2016

I think it's good now http://ci.ros2.org/job/ci_linux/1197/testReport/ (the rclpy tests started failing in build 1191 and I started testing in build 1192)

@wjwwood
Copy link
Member

wjwwood commented Apr 16, 2016

@jacquelinekay you might want to have a look at this: http://ci.ros2.org/job/ci_linux/1197/testReport/nose.failure/Failure/runTest/

@wjwwood
Copy link
Member

wjwwood commented Apr 16, 2016

lgtm, I tested it locally and it works as expected.

@wjwwood wjwwood merged commit 7e0e699 into ros2:master Apr 16, 2016
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Apr 16, 2016
ivanpauno pushed a commit that referenced this pull request Jan 2, 2020
@dirk-thomas
Merge pull request #11 from ros2/typesupport_for_rmw_impl
89900d7 
export type support for rmw implementation
mauropasse pushed a commit to mauropasse/rmw_implementation that referenced this pull request Feb 26, 2021
Merge pull request ros2#11 from mauropasse/mauro/use-void-ptr
a85bf4f 
use void * to pass executor ptr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhood @wjwwood