find_package() in root scope #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
find_package_in_root_scope
branch
from
1be7828 to
4eb9657
Compare
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Sep 8, 2015
find_package() in root scope
Member
|
Looks like one of the variables didn't get renamed, fix in #6 |
mauropasse
pushed a commit
to mauropasse/rmw_implementation
that referenced
this pull request
Oct 20, 2020
…vents-executor Revert "void return on set_events_executor_callback"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke
find_package()in the root scope (rather then in a function scope) to prevent finding the same package repeatedly. E.g. http://ci.ros2.org/job/ros2_batch_ci_linux/320/consoleFull#console-section-74http://ci.ros2.org/job/ros2_batch_ci_linux/331/consoleFull#console-section-73