fix missed variable name in refactoring #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry, good catch. I think I will update the patch to not rely on the outside variable name but actually pass it as an argument. |
Member
Author
|
Np, change it how ever you think is best. |
dirk-thomas
force-pushed
the
fix_add_exec_for_each_rmw_impl
branch
from
7952a8f to
fb2a621
Compare
Member
|
I have updated and squashed the commit. I built it locally and it created N executables again. |
Member
|
+1 |
wjwwood
added a commit
that referenced
this pull request
Sep 9, 2015
fix missed variable name in refactoring
mauropasse
pushed a commit
to mauropasse/rmw_implementation
that referenced
this pull request
Nov 19, 2020
…cutor Rename ExecutorEventCallback -> EventsExecutorCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by #5.
The result was that no implementation specific binaries were created on my machine.