refactor typesupport #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2015
Merged
dirk-thomas
force-pushed
the
refactor_typesupport
branch
from
872482b to
f9e8256
Compare
dirk-thomas
force-pushed
the
refactor_typesupport
branch
from
f9e8256 to
5eff3ff
Compare
This was referenced Dec 11, 2015
Member
Author
|
Finally ready for review: Type Support reloaded
Even a multi-rmw Windows builds works again now: http://ci.ros2.org/job/test_ci_windows_all/ we could merge the RMW specific jobs back into a single one to reduce the overhead again? While it would be good to first see that building ros2/rosidl#55 on-top of this will work out we should probably move forward anyway, merge this and then work on it in parallel to the rcl work. |
dirk-thomas
added
in review
42 tasks
Member
|
This and the related pr's lgtm |
|
I tested it and it gets me compiling and linking geometry_experimental with the patch in ros2/rclcpp#176 +1 with that patch. |
mauropasse
pushed a commit
to mauropasse/rmw_implementation
that referenced
this pull request
Feb 15, 2021
Reorder APIs arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress.
It currently builds with a single RMW impl. on Linux and OS X.