Skip to content

feat(tweepcred): do not penalize until 1.0 friend-to-follower ratio #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctjlewis
Copy link

Resubmission of #305. Closes #421.

Updates threshFriendsToFollowersRatioUMass 0.6 -> 1.0.
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023

CLA assistant check
All committers have signed the CLA.

@ElijahPepe
Copy link

There's a reason why that pull request was closed. If you'd like to discuss upping the ratio, I suggest you do it in a GitHub issue.

threshFriendsToFollowersRatioUMass is used in two places in "the algorithm": the first to calculate reputation, and the second to calculate user mass. This pull request only addresses the first. Barring that, there are several calculations made that depend on this number.

For user mass, if a user follows more than 500 users and the ratio of users they follow to users following them exceeds threshFriendsToFollowersRatioUMass, their mass is divided by the product of constantDivisionFactorGt_threshFriendsToFollowersRatioUMass and their ratio (friendsToFollowersRatio) subtracted by threshFriendsToFollowersRatioUMass.

@ctjlewis
This comment was marked as a violation of GitHub Acceptable Use Policies
@ElijahPepe
Copy link

You don't have maintainer permissions over this repository and have no idea why it was closed, and definitely didn't review it.

No, I don't, but I would imagine that Twitter engineers are not particularly eager to merge pull requests from outsiders that would significantly affect how the site's anti-spam function operates.

@ctjlewis
Copy link
Author

ctjlewis commented Apr 1, 2023

That's an understandable perspective. Why don't you let those engineers review it, and sit down and behave in the meantime?

I have sent in a PR and now the people with ownership over the code will review it. The PR is here merely as a convenience to attach to the issue, I'm sure you know how this works.

@nravic
Copy link

nravic commented Apr 3, 2023

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tweepcred: Do not penalize users until 1.0 following-to-follower ratio
4 participants