simple android support #70
Conversation
| } | ||
| }) | ||
| if (Platform.OS == 'android') { | ||
| this.scrollToFocusedInputWithNodeHandle(currentlyFocusedField) |
There was a problem hiding this comment.
This is going to fail in Android if there are in the same scene multiple KeyboardAwareScrollViews. All will receive the event but the ones that doesn't include the input as a descendant will crash.
| }) | ||
| if (Platform.OS == 'android') { | ||
| this.scrollToFocusedInputWithNodeHandle(currentlyFocusedField) | ||
| }else { |
There was a problem hiding this comment.
Please, add an space before else.
| (isAncestor) => { | ||
| if (isAncestor) { | ||
| // Check if the TextInput will be hidden by the keyboard | ||
| UIManager.measureInWindow(currentlyFocusedField, (x, y, width, height) => { |
There was a problem hiding this comment.
Only viewIsDescendantOf is not available in Android, this could be included in your PR too.
| if (Platform.OS == 'ios') { | ||
| this.keyboardWillShowEvent = Keyboard.addListener('keyboardWillShow', this.updateKeyboardSpace) | ||
| this.keyboardWillHideEvent = Keyboard.addListener('keyboardWillHide', this.resetKeyboardSpace) | ||
| }else { |
| this.keyboardWillShowEvent = Keyboard.addListener('keyboardWillShow', this.updateKeyboardSpace) | ||
| this.keyboardWillHideEvent = Keyboard.addListener('keyboardWillHide', this.resetKeyboardSpace) | ||
| }else { | ||
| this.keyboardWillShowEvent = Keyboard.addListener('keyboardDidShow', this.updateKeyboardSpace) |
There was a problem hiding this comment.
Noob question here. Why using different events for Android and iOS?
There was a problem hiding this comment.
@alvaromb Android doesn't have keyboardWillShow event :/
|
UIManager.viewIsDescendantOf is not available in android. If this scroll view not contain input, we do not use this component. Anyway, hoping you can add android supporting |
|
Closed in favor of #147 |
Just make it can work normal in android.